Login | Register
My pages Projects Community openCollabNet

Discussions > dev > [PATCH] Messages work across mailing lists now

eyebrowse
Discussion topic

Back to topic list

[PATCH] Messages work across mailing lists now

Reply

Author Andreas Guenther <aguenther at collab dot net>
Full name Andreas Guenther <aguenther at collab dot net>
Date 2002-07-24 06:16:35 PDT
Message Hello EB Team,

If one user posts a message to a mailing list, and then another user replies to the message, but to a different list, then EB tries to provide links to browse
the thread, but the links are bad.

This happens if we e.g. set reply-to on all of our cvs@project mailing lists to go to the dev@mailing list. Subversion hit this problem with a reply
to their svn@ mailing list going to dev@.

The orginal message is at:
http://subversion.ti​gris.org/servlets/Re​adMsg?list=svn&m​sgNo=2353 <http://subversion.ti​gris.org/servlets/Re​adMsg?list=svn&m​sgNo=2353>
This message offers a link to the next message in thread as:
http://subversion.ti​gris.org/servlets/Re​adMsg?list=svn&m​sgNo=15255 <http://subversion.ti​gris.org/servlets/Re​adMsg?list=svn&m​sgNo=15255>
which causes an error, the correct link should be:
http://subversion.ti​gris.org/servlets/Re​adMsg?list=dev&m​sgNo=15255 <http://subversion.ti​gris.org/servlets/Re​adMsg?list=dev&m​sgNo=15255>

This patch solves the problem of wrong/dead links, message order and
also takes care of deleted messages in this context. But there are still
some odds about this. E.g. the number of threads shown in the 'Summarize
mailing list' page' equals the actual number of submitted messages to
that particular list and not the actual number of messages posted to
that thread. Subversion e.g. always shows only one in the CVS list but
many CVS threads contain more than one message since the reply was send
to DEV. What basically happens is that both mailing list thread views
for the same initial message (thread) contain the total number of
messages of both lists. But the total of each list is only displayed.
After a discussion with dlr we came to the conclusion that a new view
seems to be necessary, which separates threads from lists. This will be
the follow up on this issue in the near future.

[src/java/org/tigris​/eyebrowse/Eyebrowse​Db.java]
- Changed sql statement and added functions to support cross lists correctly
- Added column to eb_Message (threadMsgNo)
- Next/Prev on all takes deleted messages into account now (not showing
them)
- Changed all Vectors into ArrayLists

[src/java/org/tigris​/eyebrowse/ListMaint​.java]
- Call new EyebrowseDB function con.message_setMsgNo(...)

[patching file src/java/org/tigris/​eyebrowse/core/ReadM​sg.java]
- Some clean up

[patching file src/sql/eyebrowse-create.sql]
- Added new column threadMsgNo, which contains contains the number of a
msg within a thread and supports next/prev across lists (listId).

Andreas

« Previous message in topic | 1 of 8 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Messages work across mailing lists now Andreas Guenther <aguenther at collab dot net> Andreas Guenther <aguenther at collab dot net> 2002-07-24 06:16:35 PDT
     Re: [PATCH] Messages work across mailing lists now Andreas Guenther <aguenther at collab dot net> Andreas Guenther <aguenther at collab dot net> 2002-07-24 09:13:46 PDT
         [VOTE] CVS commit for Andreas Guenther dlr Daniel Rall 2002-07-24 16:55:53 PDT
             Re: [VOTE] CVS commit for Andreas Guenther edk Ed Korthof 2002-07-24 16:53:47 PDT
                 Re: [VOTE] CVS commit for Andreas Guenther Michael Salmon <ms at formulae dot org> Michael Salmon <ms at formulae dot org> 2002-07-24 18:00:10 PDT
                     Re: [VOTE] CVS commit for Andreas Guenther dlr Daniel Rall 2002-07-24 20:57:23 PDT
                         Re: [VOTE] CVS commit for Andreas Guenther Andreas Guenther <aguenther at collab dot net> Andreas Guenther <aguenther at collab dot net> 2002-07-25 05:07:11 PDT
         Re: [PATCH] Messages work across mailing lists now dlr Daniel Rall 2002-07-24 21:01:40 PDT
Messages per page: